RFR: 8366461: Remove obsolete method handle invoke logic [v3]

Dean Long dlong at openjdk.org
Wed Sep 24 21:40:44 UTC 2025


On Wed, 24 Sep 2025 11:10:22 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - revert whitespace change
>>  - undo debug changes
>>  - cleanup
>
> src/hotspot/cpu/arm/arm_32.ad line 436:
> 
>> 434:   bool far = (_method == nullptr) ? maybe_far_call(this) : !cache_reachable();
>> 435:   return (far ? 3 : 1) * NativeInstruction::instruction_size;
>> 436: }
> 
> Why do we still need the `instruction_size` offset? Are all static java calls now method handles?

The offset is in bytes, so we still need to convert from instruction count to bytes with instruction_size.  This change adjusts for the fact that method handle calls have 1 fewer instruction on arm32 now, because preserve_SP was removed.

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java line 1:
> 
>> 1: /*
> 
> Please update the copyright year.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27059#discussion_r2377135523
PR Review Comment: https://git.openjdk.org/jdk/pull/27059#discussion_r2377136479


More information about the serviceability-dev mailing list