RFR: 8366461: Remove obsolete method handle invoke logic [v3]
Manuel Hässig
mhaessig at openjdk.org
Thu Sep 25 06:51:09 UTC 2025
On Wed, 24 Sep 2025 22:16:17 GMT, Dean Long <dlong at openjdk.org> wrote:
>> src/hotspot/cpu/arm/frame_arm.cpp line 365:
>>
>>> 363: DEBUG_ONLY(verify_deopt_original_pc(sender_nm, _unextended_sp));
>>> 364: }
>>> 365: }
>>
>> All of this could be `NOT_PRODUCT` and the method `const` if I did not miss any side effects.
>
> Right, there is no adjustment anymore on any platform. I think this function and verify_deopt_original_pc only ever existed to support code that is now getting removed. So I could change the name to verify_unextended_sp() and make it const, but it might make more sense to remove both this function and verify_deopt_original_pc now. What do you think?
I would rather keep this code as a debug only sanity check, but I would refactor it into a single function. Then the question remains what to do with the SA code, that still does nothing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27059#discussion_r2377932365
More information about the serviceability-dev
mailing list