RFR: 8367656: Refactor Constantpool's operand array into two [v7]

Johan Sjölen jsjolen at openjdk.org
Thu Sep 25 12:13:32 UTC 2025


On Tue, 23 Sep 2025 04:11:20 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/operands-again' into operands-again
>>  - Fix BSM naming
>
> src/hotspot/share/oops/constantPool.hpp line 116:
> 
>> 114:     return _argument_count;
>> 115:   }
>> 116:   int argument(int n) const {
> 
> Q: Why was the function name changed?

I think `argument_index` sounds a bit misleading, "the nth argument" makes more sense imo. Yes, I introduced the original name :-).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2378875552


More information about the serviceability-dev mailing list