RFR: 8367656: Refactor Constantpool's operand array into two [v7]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Sep 26 07:26:31 UTC 2025
On Thu, 25 Sep 2025 12:15:42 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> src/hotspot/share/oops/constantPool.hpp line 128:
>>
>>> 126:
>>> 127: // The BSMAttributeEntries stores the state of the BootstrapMethods attribute.
>>> 128: class BSMAttributeEntries {
>>
>> Nit: I'm thinking if it would make sense to rename it to `BSMEntries`.
>> Then we could rename this as well: `BSMAttributeEntry` => `BSMEntry`.
>> It feels like it will increase the readability as it is already clear that `BSMEntry` is about `BSM` attributes.
>
> Hmm, I don't want to go into renaming them in this PR. I think that's something that can be done separately.
Why not? This PR is introducing these two classes. It is better to do in a simplified form. :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2381144985
More information about the serviceability-dev
mailing list