RFR: 8377797: Remove SA support for MethodData and the printmdo command [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Feb 18 13:18:52 UTC 2026


On Tue, 17 Feb 2026 19:25:33 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove the doc.
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 863:
> 
>> 861:         },
>> 862:         new Command("printall", "printall", false) {
>> 863:             // Print every MDO in the heap or the one referenced by expression.
> 
> I just noticed this comment for `printall` and it doesn't seem right. It mentions printing MDOs, but that is what you are removing. The implementation seems to print each Method. Maybe that normally includes MethodData, but I don't think so since I don't see any signs of it getting the MethodData and calling mdo.printDataOn() like `printmdo` does. Maybe all we need here is a minor comment update to replace "MDO" with "Method".

Thanks for noticing this.  The comment also isn't accurate because it doesn't print a selected method.  I've updated it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29693#discussion_r2822279154


More information about the serviceability-dev mailing list