RFR: 8373944: ObjectMonitor::ExitOnSuspend can call java_lang_VirtualThread::set_onWaitingList() while in safepoint
David Holmes
dholmes at openjdk.org
Fri Feb 20 02:32:01 UTC 2026
On Thu, 19 Feb 2026 16:36:01 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
> Please review the following patch. `ExitOnSuspend::operator()` may run while a safepoint is in progress, which can lead to crashes because releasing the monitor involves touching oops if the successor is a virtual thread. The proposed fix is to process pending operations before releasing the monitor.
> I added a new test that reliably reproduces the issue with the extra `assert_not_at_safepoint()` added in this patch, and verified the issue is now fixed.
>
> Thanks,
> Patricio
Fix looks good. Thanks
Nice test! Five Phasers plus a CountDownLatch - wow!
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29822#pullrequestreview-3829542170
More information about the serviceability-dev
mailing list