RFR: 8376185: NoSuchFieldError thrown after a record with type annotation retransformed [v6]

[Serguei Spitsyn]

On Thu, 12 Feb 2026 13:47:49 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> …retransformed
>> 
>> Fix a retransform error when retransforming a record with type annotation. processing the record type annotation was done by calling the wrong method and using the one to process regular annotation. Regular annotations have not the same structure and decoding was therefore incorrect. The decoding methods detect a problem but this error was not propagated correctly outside of VM_RedfineClass::load_new_class_versions method, swallowing the error and leaving the retransformed class in bad state.
>> 
>> Here we have fixed the call to the right method for decoding the type annotations but also propagated the error when rewriting the constant pool as an JVMTI_ERROR_INTERNAL
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix whitespaces

Than you for the updates! It looks pretty good in general. I posted a couple of nits. Also, I'm curious what testing was done to make sure there are no regressions introduced.

test/jdk/java/lang/instrument/RetransformRecordTypeAnn/RunAsmTools.java line 1:

> 1: import java.io.File;

Nit: It seems the copyright header is missed here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29445#pullrequestreview-3846438314
PR Review Comment: https://git.openjdk.org/jdk/pull/29445#discussion_r2845729044