RFR: 8378194: Protect process_pending_interp_only() work with JvmtiThreadState_lock [v5]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Feb 26 03:54:04 UTC 2026
On Thu, 26 Feb 2026 00:02:21 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Okay, thanks. Replaced with `load_acquire`/`release_store`.
>
> Well, I think that load_relaxed should be enough here.
>
> The `_seen_interp_only_mode` and `_pending_interp_only_mode` are updated with the JvmtiThreadState_lock and changes should be visible together after lock is released.
>
> So even `_seen_interp_only_mode` is relaxed load/store and might be reordered with `_pending_interp_only_mode`, it is not possible that
> `_pending_interp_only_mode` is true in the `JvmtiThreadState::enter_interp_only_mode()`
> while
> `_seen_interp_only_mode`
> is still false.
>
> It might be possible that it becomes 'true' while the recompute enabled is still in process, but it is ok.
Thank you, Leonid. I have already pushed the update. Keeping `load_acquire/release_store` should be okay for now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29800#discussion_r2856731478
More information about the serviceability-dev
mailing list