RFR: 8373367: interp-only mechanism fails to work for carrier threads in a corner case [v12]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Feb 26 22:49:34 UTC 2026
> The `interp-only` mechanism is based on the `JavaThread` objects. Carrier and virtual threads can temporary share the same `JavaThread`. The `java_thread->jvmti_thread_state()` is re-linked to a virtual thread at `mount` and to the carrier thread at `unmount`. The `JvmtiThreadState` has a back link to the `JavaThread` which is also set for virtual thread at a `mount` and carrier thread at an `unmount`. Just one of these two links at the same time is set to the `JavaThread`, the other one has to be set to `nullptr`. The `interp-only` mechanism needs this invariant.
> However, there is a corner case when this invariant is broken. It happens when the `JvmtiThreadState` for carrier thread has just been created. In such case, the link to `JavaThread` is always `non-nullptr` even though a virtual thread is currently mounted on a carrier thread. This simple update fixes the issue in the `JvmtiThreadState` ctor.
>
> Also, this update the includes the `interp_only` implementation simplifications and more asserts are added to relevant places. One of the simplification is a removal of the field `JvmtiThreadState::_thread_saved`.
>
> Testing:
> - TBD: Mach5 tiers 1-6
Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
review: add one more clarification in a comment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29436/files
- new: https://git.openjdk.org/jdk/pull/29436/files/cd6dc95e..2eea0ed9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29436&range=11
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29436&range=10-11
Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/29436.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29436/head:pull/29436
PR: https://git.openjdk.org/jdk/pull/29436
More information about the serviceability-dev
mailing list