RFR: 8376185: NoSuchFieldError thrown after a record with type annotation retransformed [v6]
David Holmes
dholmes at openjdk.org
Thu Feb 26 23:00:57 UTC 2026
On Thu, 26 Feb 2026 22:49:50 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix whitespaces
>
> test/jdk/java/lang/instrument/RetransformRecordTypeAnn/TestRetransformRecord.java line 36:
>
>> 34: * @compile ../NamedBuffer.java
>> 35: * @run driver RunAsmTools altered/MyRecord.jcod altered
>> 36: * @compile MyRecord.java
>
> It is always risky to assume stability in javac output, even with `--release` flag - javac can always have translation strategy improvements that bring in potentially unwanted changes to the resulting class files.
>
> I recommend just having two versions of `MyRecord.jcod` so they are both stable, and it's easier for readers to notice their difference.
I don't think that should be a concern here, as long as the manual mods to the jcod could never be something javac would generate for the original Java source. Of course I still don't know exactly what those mods are so I'm still assuming.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29445#discussion_r2861715689
More information about the serviceability-dev
mailing list