RFR: 8378110: Add -XX: prefix to settings-file flags in RuntimeMXBean.getInputArguments() [v2]
Kevin Walls
kevinw at openjdk.org
Fri Feb 27 15:20:01 UTC 2026
On Fri, 27 Feb 2026 15:04:45 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:
>> Either is usable. The else might be best as it could even throw a SkippedException or just throw a failure as a misconfigred/specified test.
>> As you mention we probably can't reliably test for empty getInputArguments(), unless we specifically start a new process, but think we don't need to go that far right now.
>
> Actually I prefer removal over throwing an exception - the first test case explicitly passes no arguments, it's the incidental nature of the test harness that arguments do make their way to us. So if the test suite suddenly stopped interfering, that doesn't seem wrong exactly and I'd prefer the test to continue on its merry way (and ideally fail if getInputArguments returns null, which it will in this case although mostly incidentally).
OK all good. (We don't really need the vmOptions any more at all, it's just args all the way, but that's not much different to the original. )
Looks good to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29793#discussion_r2864827067
More information about the serviceability-dev
mailing list