RFR: 8366659: ObjectMonitor::wait() liveness problem with a suspension request [v32]

Anton Artemov aartemov at openjdk.org
Wed Jan 28 09:26:19 UTC 2026


On Wed, 28 Jan 2026 02:31:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8366659: Addressed reviewer's comment.
>
> src/hotspot/share/runtime/objectMonitor.cpp line 2244:
> 
>> 2242:   assert(was_notified || state == ObjectWaiter::TS_RUN,
>> 2243:     "was not notified and is not in the right state: was_notified = %s, state = %s",
>> 2244:     was_notified ? "true" : "false", node->getTStateName(state));
> 
> Suggestion:
> 
>   assert(was_notified || state == ObjectWaiter::TS_RUN,
>          "was not notified and is not in the right state: was_notified = %s, state = %s",
>          was_notified ? "true" : "false", node->getTStateName(state));
> 
> Fix indent.
> 
> Printing was_notified is redundant though as the assert can only fail if it is false.

Thanks for spotting, addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27040#discussion_r2735645462


More information about the serviceability-dev mailing list