<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks good! But I wonder why there is a shell script involved. Couldn't this be just a straightforward java file with several @run tags?<br><br>Thanks,<br>/Staffan<br><br><div><div>On 11 okt 2013, at 20:02, Stefan Karlsson <<a href="mailto:stefan.karlsson@oracle.com">stefan.karlsson@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10/11/13 7:44 PM, Coleen Phillimore
wrote:<br>
</div>
<blockquote cite="mid:52583905.8090403@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
Stefan,<br>
<br>
I added a check about the count exceeding 1 000 000 because it
causes the test to create an invalid class file. With the
shell script changes, it won't happen but I would be happy if
that check were there so no one ever has to debug this thinking
it has a corrupted constant pool again.<br>
</div>
</blockquote>
<br>
OK. I though that was old debugging left-overs.<br>
<br>
New webrev:<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~stefank/7196801/webrev.01/">http://cr.openjdk.java.net/~stefank/7196801/webrev.01/</a><br>
<br>
thanks,<br>
StefanK<br>
<br>
<blockquote cite="mid:52583905.8090403@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
Thanks,<br>
Coleen<br>
<br>
On 10/11/2013 1:33 PM, Stefan Karlsson wrote:<br>
</div>
<blockquote cite="mid:52583650.6060700@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Please, review this test fix.<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Estefank/7196801/webrev.00/">http://cr.openjdk.java.net/~stefank/7196801/webrev.00/</a><br>
<br>
Most of the fix was implemented by Coleen, I've only done some
small tweaks and updated some comments.<br>
<br>
The fix depends on these changes:<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
JDK-8025996 Track metaspace usage when metaspace is expanded <br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
JDK-8024547 MaxMetaspaceSize should limit the committed memory
used by the metaspaces<br>
<br>
Both of these changesets have been pushed to hotspot-gc and are
currently undergoing testing. LowMemoryTest2 can only be removed
from the test/ProblemList.txt when both JDK-8025996 and
JDK-8024547 have propagated through all necessary repositories.<br>
<br>
thanks,<br>
StefanK<br>
</blockquote>
<br>
</blockquote>
<br>
</div>
</blockquote></div><br></body></html>