<html>
<head>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Staffan,<br>
<br>
could you please be my sponsor and push this fix?<br>
<br>
<span id="result_box" class="" lang="en"><span class="hps">I have
discovered</span> <span class="hps">three</span> <span
class="hps">more tests</span> <span class="hps">that should be</span><span
class="hps"> changed</span></span>:<br>
sun/management/jmxremote/bootstrap/CustomLauncherTest.java<br>
java/lang/management/MemoryMXBean/CollectionUsageThreshold.java<br>
java/lang/management/MemoryMXBean/LowMemoryTest.java<br>
<br>
The webrev that includes them can be found here: <a
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eykantser/8034960/webrev.02/">http://cr.openjdk.java.net/~ykantser/8034960/webrev.02/</a><br>
<br>
Thanks,<br>
Katja<br>
<br>
<div class="moz-forward-container"><br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Subject:
</th>
<td>Re: RFR(S): 8034960: Serviceability tests using @library
failing with java.lang.NoClassDefFoundError</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Date: </th>
<td>Fri, 9 May 2014 12:48:56 +0200</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">From: </th>
<td>Staffan Larsen <a class="moz-txt-link-rfc2396E"
href="mailto:staffan.larsen@oracle.com"><staffan.larsen@oracle.com></a></td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">To: </th>
<td>Yekaterina Kantserova <a class="moz-txt-link-rfc2396E"
href="mailto:yekaterina.kantserova@oracle.com"><yekaterina.kantserova@oracle.com></a></td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">CC: </th>
<td>Alan Bateman <a class="moz-txt-link-rfc2396E"
href="mailto:Alan.Bateman@oracle.com"><Alan.Bateman@oracle.com></a>,
<a class="moz-txt-link-rfc2396E"
href="mailto:serviceability-dev@openjdk.java.netserviceability-dev@openjdk.java.net">"serviceability-dev@openjdk.java.net
serviceability-dev@openjdk.java.net"</a> <a
class="moz-txt-link-rfc2396E"
href="mailto:serviceability-dev@openjdk.java.net"><serviceability-dev@openjdk.java.net></a>,
core-libs-dev Libs <a class="moz-txt-link-rfc2396E"
href="mailto:core-libs-dev@openjdk.java.net"><core-libs-dev@openjdk.java.net></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Looks good!
Thanks,
/Staffan
On 9 maj 2014, at 12:43, Yekaterina Kantserova <a class="moz-txt-link-rfc2396E" href="mailto:yekaterina.kantserova@oracle.com"><yekaterina.kantserova@oracle.com></a> wrote:
> Hi,
>
> The version b09 of JTreg which contains <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/CODETOOLS-7900178">https://bugs.openjdk.java.net/browse/CODETOOLS-7900178</a> has been promoted. So it seems to be time to push the fix for JDK-8034960. I've made a new webrev to be sure the changes fit in in the latest jdk9 source. The webrev can be found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01.
>
> Thanks,
> Katja
>
>
>
> On 03/25/2014 01:14 PM, Staffan Larsen wrote:
>> I’ve looked at a random sample of these changes and they look ok.
>>
>> Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
>>
>> I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
>>
>> Thanks,
>> /Staffan
>>
>> On 25 mar 2014, at 13:07, Yekaterina Kantserova <a class="moz-txt-link-rfc2396E" href="mailto:yekaterina.kantserova@oracle.com"><yekaterina.kantserova@oracle.com></a> wrote:
>>
>>> Hi,
>>>
>>> Could I please have a review of this fix.
>>>
>>> webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Eykantser/8034960/webrev.00/">http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/</a>
>>> bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8034960">https://bugs.openjdk.java.net/browse/JDK-8034960</a>
>>>
>>> When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
>>>
>>> Verified locally since no JTreg with fix has been promoted yet.
>>>
>>>
>>> Thanks,
>>> Katja
>
</pre>
<br>
</div>
<br>
</body>
</html>