<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Paru,<br>
<br>
It looks good.<br>
Thank you a lot for taking care about this!<br>
<br>
Could we get at least one more review from the Serviceability team
on this new test?<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 2/2/18 09:35, Paru Somashekar wrote:<br>
</div>
<blockquote type="cite" cite="mid:5A74A169.5020604@oracle.com">
<meta http-equiv="Context-Type" content="text/html;
charset=ISO-8859-1">
Hi, <br>
<br>
Please review the fix for JDK-8193150. <br>
<br>
The fix introduces a new jtreg test, NashornPopFrameTest. It is
based on the original test from <a
href="https://bugs.openjdk.java.net/browse/JDK-8187143"
moz-do-not-send="true">JDK-8187143</a> that was provided by the
customer.<br>
<br>
Bug : <a href="https://bugs.openjdk.java.net/browse/JDK-8193150"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8193150
</a><br>
Webrev : <a
href="http://cr.openjdk.java.net/%7Epsomashe/8193150/webrev/"
moz-do-not-send="true">http://cr.openjdk.java.net/~psomashe/8193150/webrev/</a><br>
<br>
Here is a brief description of what the test does :-<br>
<br>
* The debuggee, creates and uses a Nashorn engine to evaluate a
simple script. <br>
<br>
* The debugger tries to set a breakpoint in Nashorn’s internal
DEBUGGER method.<br>
* When the breakpoint is reached, it looks for stack frame whose
method's declaring type name starts with (nashorn dynamically
generated classes) ”jdk.nashorn.internal.scripts.Script$”. <br>
* It then pops stack frames using the ThreadReference.popFrames()
call, up to and including the above stackframe.<br>
* The execution of the debuggee application is resumed after the
needed frames have been popped.<br>
<br>
This test is included in the ProblemList as it fails under some
circumstances (bug <a
href="https://bugs.openjdk.java.net/browse/JDK-8187143"
moz-do-not-send="true">JDK-8187143)</a>. Is always passes with
the -Xint flag however always fails with -Xcomp. It fails
intermittently with the -Xmixed (default). <br>
<br>
thanks,<br>
Paru. </blockquote>
<br>
</body>
</html>