<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-DE" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Hi Mark,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">what is the process now going forward?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Johannes<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Bechberger, Johannes <johannes.bechberger@sap.com><br>
<b>Date: </b>Tuesday, 11. October 2022 at 10:18<br>
<b>To: </b>Mark Reinhold <mark.reinhold@oracle.com><br>
<b>Cc: </b>andrei.pangin@gmail.com <andrei.pangin@gmail.com>, Langer, Christoph <christoph.langer@sap.com>, jaroslav.bachorik@datadoghq.com <jaroslav.bachorik@datadoghq.com>, serviceability-dev@openjdk.org <serviceability-dev@openjdk.org><br>
<b>Subject: </b>Re: Submitted JEP: Asynchronous Stack Trace VM API<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Thanks for your comments. I incorporated them in the updated version of the JEP and updated all related repositories that now are implemented based on current JDK20
head and async-profiler head. The implementation of the JEP now resides in the sandbox repository too.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Regards</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Johannes</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Mark Reinhold <mark.reinhold@oracle.com><br>
<b>Date: </b>Wednesday, 5. October 2022 at 00:05<br>
<b>To: </b>Bechberger, Johannes <johannes.bechberger@sap.com><br>
<b>Cc: </b>andrei.pangin@gmail.com <andrei.pangin@gmail.com>, Langer, Christoph <christoph.langer@sap.com>, jaroslav.bachorik@datadoghq.com <jaroslav.bachorik@datadoghq.com>, serviceability-dev@openjdk.org <serviceability-dev@openjdk.org><br>
<b>Subject: </b>Submitted JEP: Asynchronous Stack Trace VM API</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt"><a href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenjdk.org%2Fjeps%2F8284289&data=05%7C01%7Cjohannes.bechberger%40sap.com%7Ce4bb4293c6dd4dc6112f08daa65490bf%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638005179392019024%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OkizIAXRzVPb3lbfugQn%2BFwdQdGN7YBO7lDNrEDrj2M%3D&reserved=0">https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenjdk.org%2Fjeps%2F8284289&data=05%7C01%7Cjohannes.bechberger%40sap.com%7Ce4bb4293c6dd4dc6112f08daa65490bf%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638005179392019024%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OkizIAXRzVPb3lbfugQn%2BFwdQdGN7YBO7lDNrEDrj2M%3D&reserved=0</a><br>
<br>
Thanks for this submission.<br>
<br>
To start, I’ve shortened the title of the JEP to something that’s<br>
hopefully more recognizable.<br>
<br>
I won’t comment here on the technical merits of the draft, though I may<br>
do so elsewhere. For now, some editorial and procedural questions and<br>
suggestions:<br>
<br>
- In the Summary you say that the API will be “secure.” How will it<br>
be any more secure than the existing `AsyncGetCallTrace` API? The<br>
JEP text does not say.<br>
<br>
- One of your goals is to “Support asynchronous usage as well as<br>
calling the API from signal handlers.” Isn’t calling the API from a<br>
signal handler a special case of asynchronous usage?<br>
<br>
- You state that “The new API shall not be recommended for production<br>
usage.” If it’s not for production usage then:<br>
<br>
- Will using the API require -XX:+UnlockExperimentalVMOptions?<br>
<br>
- What does the use of the word “supported” in the Summary<br>
actually mean?<br>
<br>
- You note that one of the flaws of the existing API is that it’s not<br>
exported in any header. Via which header file will this new API be<br>
exported?<br>
<br>
- For IP clarity, please make your prototype implementation available<br>
in an OpenJDK repository, for example the JDK Sandbox repository.<br>
<br>
- In the Testing section, you say that “Unifying the existing<br>
profiling-related stack walking code allows for testing it more<br>
efficiently by combining the existing tests.” This JEP no longer<br>
proposes such a unification, so please adjust this text.<br>
<br>
- Mark</span><o:p></o:p></p>
</div>
</div>
</body>
</html>