RFR: C1 cleanup

Aleksey Shipilev shade at redhat.com
Thu Dec 8 11:05:46 UTC 2016


On 12/08/2016 12:00 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/c1-cleanup/webrev.00/

*) Shouldn't this assert be on lir_cas_long branch only? Or is it in upstream
that (odd) way?

1600 void LIR_Assembler::emit_compare_and_swap(LIR_OpCompareAndSwap* op) {
1601   assert(VM_Version::supports_cx8(), "wrong machine");

*) Please break this line:
1461   LIR_OpShenandoahWriteBarrier(LIR_Opr obj, LIR_Opr result, CodeEmitInfo*
info, bool need_null_check) : LIR_Op1(lir_shenandoah_wb, obj, result, T_OBJECT,
lir_patch_none, info), _need_null_check(need_null_check) {

Otherwise looks good.

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list