RFR: Improve AryEq
Roman Kennke
rkennke at redhat.com
Tue Dec 20 17:48:31 UTC 2016
Am Dienstag, den 20.12.2016, 12:15 +0100 schrieb Aleksey Shipilev:
> On 12/20/2016 12:10 PM, Roman Kennke wrote:
> > This adds an cmp-barrier to the code generated by AryEq. A false
> > negative in the array ptr comparison would result in the slow-path
> > being taken, even though it's not necessary. The barrier should get
> > us
> > on the fast path more often.
> >
> > Ok?
> >
> > http://cr.openjdk.java.net/~rkennke/aryeq/webrev.00/
>
> Looks okay, but would be interesting to see if we can merge null-
> checking paths
> with acmp barrier?
That would be complicated. Would need build special code just for this
intrinsics... Doesn't seem worth for now. I'm pushing as is.
Roman
More information about the shenandoah-dev
mailing list