CAS code misses check for null

Andrew Haley aph at redhat.com
Tue Jun 14 10:03:06 UTC 2016


On 14/06/16 10:51, Roland Westrelin wrote:
> Here is a new webrev:
> 
> http://cr.openjdk.java.net/~roland/cas-null/webrev.01/
> 
> Great you spotted that bug. I tried too hard to be clever...

This stuff seems to be very hard to get right.

The indentation here is wrong:

2218   if (!acquire) dmb(LD); // Required: updates to the brooks pointer
2219   // could be missed otherwise

Andrew.



More information about the shenandoah-dev mailing list