AArch64 port
Roman Kennke
rkennke at redhat.com
Mon Mar 14 16:50:57 UTC 2016
Am Montag, den 14.03.2016, 15:40 +0000 schrieb Andrew Haley:
> http://cr.openjdk.java.net/~aph/aarch64-shenandoah/
Can't really say much about the aarch64 specific changes, I'll comment
on shared-code changes only and trust that you did the right thing on
your side ;-)
The only thing that sticks out to me is that you added includes in the
following files. Are they necessary? I don't see how...
src/share/vm/gc/shenandoah/shenandoahBarrierSet.cpp
src/share/vm/gc/shenandoah/shenandoahRootProcessor.cpp
src/share/vm/gc/shenandoah/shenandoahRootProcessor.hpp
And in shenandoahHeap.hpp, you moved num_regions() and max_regions()
up. I think they should stay where they are. It's 'formatting' only...
they used to sit next to all the other Shenandoah specific methods, and
you moved them up to sit next to all the overridden CollectedHeap
methods.
Roman
More information about the shenandoah-dev
mailing list