AArch64 port

[Roman Kennke]

Am Montag, den 14.03.2016, 17:06 +0000 schrieb Andrew Haley:
> On 03/14/2016 04:50 PM, Roman Kennke wrote:
> > Am Montag, den 14.03.2016, 15:40 +0000 schrieb Andrew Haley:
> > > http://cr.openjdk.java.net/~aph/aarch64-shenandoah/
> > 
> > Can't really say much about the aarch64 specific changes, I'll
> > comment
> > on shared-code changes only and trust that you did the right thing
> > on
> > your side ;-)
> > 
> > The only thing that sticks out to me is that you added includes in
> > the
> > following files. Are they necessary? I don't see how...
> > 
> > src/share/vm/gc/shenandoah/shenandoahBarrierSet.cpp
> > src/share/vm/gc/shenandoah/shenandoahRootProcessor.cpp
> > src/share/vm/gc/shenandoah/shenandoahRootProcessor.hpp
> 
> Yes, thgy were all missing.  My guess is that you use precompiled
> headers, so you never noticed.

Ok then.

> > And in shenandoahHeap.hpp, you moved num_regions() and
> > max_regions()
> > up. I think they should stay where they are. It's 'formatting'
> > only...
> > they used to sit next to all the other Shenandoah specific methods,
> > and
> > you moved them up to sit next to all the overridden CollectedHeap
> > methods.
> 
> Oh, sorry.  IIRC the problem was that they were private.

Ah. Ok. They are infact in the right place now.

>From my side, the patch is ok to be committed. Gotta wait for Iris to
give you push access I think.

Roman