RFR: Better handling of cancelled_gc

Roman Kennke rkennke at redhat.com
Wed Nov 9 14:47:34 UTC 2016


Am Mittwoch, den 09.11.2016, 15:32 +0100 schrieb Aleksey Shipilev:
> On 11/09/2016 03:20 PM, Roman Kennke wrote:
> > 
> > http://cr.openjdk.java.net/~rkennke/cancelgc/webrev.01/
> 
> Volatile changes look good.
> 
> The loop itself:
>   - Make 1000 an experimental option, and read it once before
> entering
> the loop?

Done.

>   - New code exits the loop on cancelled_concgc, without consulting
> the
> terminator? Can it be that other threads are stuck waiting in
> terminator
> for our quitter to show up?

Ah right. Done too:

http://cr.openjdk.java.net/~rkennke/cancelgc/webrev.02/

ok now?

Roman



More information about the shenandoah-dev mailing list