RFR (S): Single-element buffer in thread-local taskqueues

[Zhengyu Gu]

Ok

Thanks,

-Zhengyu



On 11/09/2016 10:02 AM, Aleksey Shipilev wrote:
> On 11/09/2016 03:14 PM, Zhengyu Gu wrote:
>> Would it make sense to incorporate pop_buffer() inside pop_local()?
>> since you are doing the push buffer in push()? The buffered element
>> could be easily forgotten when migrating from OverflowTaskQueue to
>> BufferedOverflowTaskQueue.
> The way taskqueues implement delegation is by introducing new methods,
> apparently: see how OverflowTaskQueue extends the GenericTaskQueue.
> pop_buffer seems to be the natural continuation of
> pop_local/pop_overflow divide...
>
> There is push() that does everything and overrides the super::push, but
> pop_*() are distinct. For consistency, I would keep it this way.
>
> Thanks,
> -Aleksey
>