RFR: Some more AArch64 CAS/CAE fixes

Aleksey Shipilev shade at redhat.com
Fri Nov 18 13:41:32 UTC 2016


On 11/17/2016 09:11 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/aarch64-cas/webrev.02/

*) I don't quite get the NoSp change. The change now allows some
operands to take SP. Was it an overlook, or AArch64 really has some
constraints about this?

*) src/cpu/aarch64/vm/macroAssembler_aarch64.cpp:

Missed one:
   if (size == word) {

Would appreciate parentheses here:
   bool is_cae = result != noreg;
   bool is_narrow = size == word;

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list