RFR: Add asserts all over synchronizer

Roman Kennke rkennke at redhat.com
Fri Oct 7 09:06:02 UTC 2016


Am Donnerstag, den 06.10.2016, 19:11 +0200 schrieb Aleksey Shipilev:
> On 10/06/2016 07:06 PM, Roman Kennke wrote:
> > 
> > Aleksey pointed out in private that we could just as well make
> > synchronizer and biasedlocking use oopDesc::cas_set_mark() and then
> > put
> > the asserts there and in oopDesc::set_mark() and
> > oopDesc::release_set_mark(). That should give us better coverage.
> > So
> > here it is:
> > 
> > http://cr.openjdk.java.net/~rkennke/assertsynchronizer/webrev.01/
> > 
> > Ok now?
> 
> Yes. Eager to see all those little places where it crashes with
> Shenandoah. Maybe run TEST="hotspot_all" on Shenandoah/fastdebug
> before
> pushing?

I don't know (yet) how to unconditionally use Shenandoah everywhere.
JAVA_TOOL_OPTIONS doesn't seem to do it.

I've run jcstress in sanity mode, and SPECjvm and didn't get any
asserts. I'd like to push it and run more tests on a big machine. Ok?

Roman


More information about the shenandoah-dev mailing list