RFR (XS): Prune is_in call from in_cset_fast_test

Roman Kennke rkennke at redhat.com
Mon Oct 17 15:00:44 UTC 2016


Yes.

(Duh. How did this happen?)

Cheers,
Roman

Am Montag, den 17.10.2016, 16:50 +0200 schrieb Aleksey Shipilev:
> 
> Hi,
> 
> The profiles on SPECjvm2008 show that ShenandoahHeap::is_in is in
> hotspots. Further analysis shows the most dominating use is
> in_cset_fast_test. It seems to me the ::is_in use there is redundant
> and
> should be instead turned into the assert -- compiled code that dubs
> this
> test blindly trusts it anyway.
> 
> Webrev:
>   http://cr.openjdk.java.net/~shade/shenandoah/in-cset-opt/webrev.01/
> 
> Testing: fastdebug/hotspot_gc_shenandoah
> 
> Thanks,
> -Aleksey
> 


More information about the shenandoah-dev mailing list