RFR(XS): Remove unused ShenandoahPrinter
Zhengyu Gu
zgu at redhat.com
Tue Aug 1 15:49:48 UTC 2017
Okay, updated:
Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/sh_printer/webrev.00/
Thanks,
-Zhengyu
On 08/01/2017 09:10 AM, Aleksey Shipilev wrote:
> Probably. And put a warning comment explaining why it is not used.
>
> -Aleksey
>
> On 08/01/2017 03:08 PM, Zhengyu Gu wrote:
>> Ah, okay then. Should we warp it around ASSERT
>>
>> -Zhengyu
>>
>> On 08/01/2017 09:03 AM, Aleksey Shipilev wrote:
>>> On 08/01/2017 02:59 PM, Zhengyu Gu wrote:
>>>> Removed no longer used ShenandoahPrinter
>>>>
>>>> http://cr.openjdk.java.net/~zgu/shenandoah/rm_sh_printer/webrev.00/
>>>
>>> Funny story about that: I had removed unused printing routines from ShenandoahHeap, but then
>>> Christine wanted to keep them around for debugging purposes. Thus ShenandoahPrinter was born, where
>>> these routines found their temporary home. And that kinda explains why it is unused. Talk to chf
>>> about that ;)
>>>
>>> Thanks,
>>> -Aleksey
>>>
>
>
More information about the shenandoah-dev
mailing list