RFR: Verify liveness data

Zhengyu Gu zgu at redhat.com
Mon Aug 7 15:39:14 UTC 2017


Good to go.

-Zhengyu

On 08/07/2017 11:37 AM, Aleksey Shipilev wrote:
> On 08/07/2017 03:49 PM, Zhengyu Gu wrote:
>> 1) ShenandoahLivenessData* _ld; -> volatile ShenandoahLivenessData* _ld;
>>
>> 2) shenandoahVerifier.cpp
>>  251           Atomic::add(obj->size() + BrooksPointer::word_size(), _ld + obj_reg->region_number());
>>
>>  ->  251           Atomic::add(obj->size() + BrooksPointer::word_size(),
>> _ld[obj_reg->region_number()]);
>
> Fixed both.
>
> It seems to me that volatility is required in ShenandoahLivenessData definition itself:
>   http://cr.openjdk.java.net/~shade/shenandoah/verifier-liveness/webrev.02/
>
> Thanks,
> -Aleksey
>


More information about the shenandoah-dev mailing list