RFR: Reclaimed humongous regions should count towards immediate garbage
Aleksey Shipilev
shade at redhat.com
Tue Aug 22 19:25:25 UTC 2017
On 08/22/2017 09:19 PM, Zhengyu Gu wrote:
> 338 if (region->is_humongous_start()) {
> 339 assert(region->has_live() == heap->is_marked_complete(oop(region->bottom() +
> BrooksPointer::word_size())),
> 340 "Humongous liveness and marks should agree");
> 341 if (!region->has_live()) {
> 342 heap->reclaim_humongous_region_at(region);
> 343 immediate_regions++;
> 344 immediate_garbage += region->garbage();
> 345 }
> 346 }
>
> #343: humongous can have more than one regions, should add all of them here?
D'uh! Of course. The minimal change for that seems to be this:
http://cr.openjdk.java.net/~shade/shenandoah/immediate-humongous/webrev.02/
-Aleksey
More information about the shenandoah-dev
mailing list