RFR: Track interior location when verifying matrix

[Roman Kennke]

Am 24.08.2017 um 23:23 schrieb Aleksey Shipilev:
> On 08/24/2017 11:09 PM, Roman Kennke wrote:
>> I ran into a crash because the verifier did not track the interior loc
>> when verifying matrix.
>>
>> I added code to avoid the crash (i.e. check _interior_loc == NULL), and
>> also added code to actually track the interior location when verifying
>> matrix.
>>
>> http://cr.openjdk.java.net/~rkennke/verifier/webrev.00/
> Shouldn't you actually save from_interior_idx from the call?
>
>  151       size_t from_interior_idx = 0;
>  152       if (_interior_loc != NULL) {
>  153         _heap->heap_region_index_containing(_interior_loc);
>  154       }
>
> Also, idx == 0 is a valid region idx...
>
> Suggestion:
>
>        size_t from_interior_idx = 0;
>        if (_interior_loc != NULL) {
>          from_interior_idx = _heap->heap_region_index_containing(_interior_loc);
>        }
>
>        if (_interior_loc != NULL) {
>          ... messages ...
>        }
>
> -Aleksey
>
Ugh, you are right. Changed exactly as you suggested:

http://cr.openjdk.java.net/~rkennke/verifier/webrev.01/
<http://cr.openjdk.java.net/%7Erkennke/verifier/webrev.01/>

Ok now?

Roman