RFR: Shenandoah string deduplication

Aleksey Shipilev shade at redhat.com
Thu Dec 7 20:47:12 UTC 2017


On 12/07/2017 09:43 PM, Zhengyu Gu wrote:
> 
> 
> On 12/07/2017 02:41 PM, Aleksey Shipilev wrote:
>> On 12/07/2017 08:34 PM, Zhengyu Gu wrote:
>>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/sh_strdedup/webrev.02/
>>
>> Looks good, thanks!
>>
>> Please run SPECjvm with fastdebug and aggressive options [1] to make sure we don't have trivial
>> bugs. If it passes, we are all good.
>>
>> -Aleksey
>>
>> [1] -foe true -f 1 -wi 5 -i 5 -t 1 -w 300ms -r 300ms --jvmArgs "-Xmx1g -Xms1g -XX:+UseShenandoahGC
>> -XX:+UnlockDiagnosticVMOptions -XX:ShenandoahGCHeuristics=aggressive -XX:+VerifyStrictOopOperations
>> -XX:+ShenandoahStoreCheck -XX:+ShenandoahVerifyOptoBarriers -XX:+ShenandoahOOMDuringEvacALot"
> 
> All clean! Can I push now?

Yes, I think so.

-Aleksey



More information about the shenandoah-dev mailing list