RFR: Don't assert Shenandoah safepoint in verifier
Roman Kennke
rkennke at redhat.com
Tue Dec 12 14:26:22 UTC 2017
Am 09.12.2017 um 01:07 schrieb Aleksey Shipilev:
> On 12/08/2017 05:07 PM, Roman Kennke wrote:
>> During testing with jdk9 and jdk8, I hit the assert for Shenandoah safepoint in the verifier at
>> least once, presumably duing verify-before-exit. This change relaxes back to asserting any safepoint
>> in verifier. Ok?
>>
>> Testing: hotspot_gc_shenandoah
>>
>> http://cr.openjdk.java.net/~rkennke/no-sh-sp/webrev.00/
>
> Not really. We should instead remove "|| !UseTLAB" in ShenandoahHeap::verify_generic, if that is the
> path we are going in.
>
> -Aleksey
>
>
Right. Like this:
http://cr.openjdk.java.net/~rkennke/no-sh-sp/webrev.01/
Still passes tests.
Roman
More information about the shenandoah-dev
mailing list