RFR: Shenandoah SA implementation

[Aleksey Shipilev]

On 12/14/2017 09:00 PM, Zhengyu Gu wrote:
> Please review Shenandoah Seviceability agent implementation.
> 
> 
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/shenandoah-sa/webrev.00/index.html

Very good!

Minor nits:

 *) Excess fully-qualified name here in HeapSummary:

 149       } else if (heap instanceof sun.jvm.hotspot.gc.shenandoah.ShenandoahHeap) {

 *) Excess leading white-space in String here in HeapSummary?

 153          System.out.println("   regions   = " + num_regions);

 *) Double spaces here after "Address" in ShenandoahHeapRegionSet:

  62         Address  arrayAddr = regionsField.getValue(addr);
  63         Address  regAddr = arrayAddr.getAddressAt(index * regionPtrFieldSize);

No need for re-review.

Thanks,
-Aleksey