RFR: Fixed compilation error of libTestHeapDump.c on Windows with VS2010

Aleksey Shipilev shade at redhat.com
Mon Dec 18 16:48:05 UTC 2017


On 12/18/2017 05:43 PM, Zhengyu Gu wrote:
> This patch fixes compilation error reported by Michal Vala [1].
> 
> VS2010 compiling C files uses C89 standard, which requires all local variables are declared at the
> beginning of code blocks.
> 
> 
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/vs2010_c2275/webrev.00/

Looks good. Fix up the triple space here?

  73     jvmtiCapabilities   capabilities;

This may go directly to sh/jdk10, and to sh/jdk9 and sh/jdk8u (with "[backport]").

Thanks,
-Aleksey




More information about the shenandoah-dev mailing list