RFR: Fix compilation errors on Windows

Aleksey Shipilev shade at redhat.com
Tue Dec 19 20:28:24 UTC 2017


On 12/19/2017 09:14 PM, Zhengyu Gu wrote:
> Fixed some compilation errors on Windows with VS2013. The compilation errors are due to recent
> atomic implementation changes.
> 
> For example:
> 
> c:\Users\zhengyu\workspace\shenandoah-jdk10\src\hotspot\shar\gc/shenandoah/shenandoahConcurrentMark.inline.hpp(77)
> : error C2668: 'ShenandoahHeapRegion::increase_live_data_words' : ambiguous call to overloaded function
> 
> c:\Users\zhengyu\workspace\shenandoah-jdk10\src\hotspot\share\gc/shenandoah/shenandoahHeapRegion.hpp(327):
> could be 'void ShenandoahHeapRegion::increase_live_data_words(jint)'
> 
> c:\Users\zhengyu\workspace\shenandoah-jdk10\src\hotspot\share\gc/shenandoah/shenandoahHeapRegion.hpp(326):
> or       'void ShenandoahHeapRegion::increase_live_data_words(size_t)'
>         while trying to match the argument list '(int)'
> 
> 
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/win_atomic_fix/webrev.00/

*) Please check it still builds on Linux?

*) Indentation is wrong:

 107   volatile int                           _clean_klass_tree_claimed;

...

 127   volatile int      _resolved_method_task_claimed;


*) I know there are j-type removals are coming from upstream:
 http://hg.openjdk.java.net/jdk/hs/rev/7cc7de9bf4a4

...maybe we should use intX_t to match?

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list