RFR: New code misses safe equals

Roman Kennke rkennke at redhat.com
Wed Jul 12 18:15:38 UTC 2017


Good! 

Run with -XX:+VerifyStrictOopOperations to catch more of those (if any).

Am 12. Juli 2017 18:59:58 MESZ schrieb Aleksey Shipilev <shade at redhat.com>:
>Obvious one:
>
>diff -r 3061c352112d src/share/vm/classfile/protectionDomainCache.cpp
>--- a/src/share/vm/classfile/protectionDomainCache.cpp	Wed Jul 12
>18:50:02 2017
>+0200
>+++ b/src/share/vm/classfile/protectionDomainCache.cpp	Wed Jul 12
>18:55:15 2017
>+0200
>@@ -117,7 +117,7 @@
>
>ProtectionDomainCacheEntry* ProtectionDomainCacheTable::find_entry(int
>index,
>Handle protection_domain) {
>for (ProtectionDomainCacheEntry* e = bucket(index); e != NULL; e =
>e->next()) {
>-    if (e->protection_domain() == protection_domain()) {
>+    if (oopDesc::equals(e->protection_domain(), protection_domain()))
>{
>       return e;
>     }
>   }
>
>Thanks,
>-Aleksey

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.


More information about the shenandoah-dev mailing list