RFR: Refactor asm acmp

[Andrew Haley]

On 18/07/17 17:17, Roman Kennke wrote:
> Am 18.07.2017 um 18:14 schrieb Andrew Haley:
>> On 18/07/17 17:00, Aleksey Shipilev wrote:
>>> On 07/18/2017 05:57 PM, Roman Kennke wrote:
>>>> Oops, some dead stuff sneaked into shenandoahBarrierSet.hpp. Removed:
>>>>
>>>> http://cr.openjdk.java.net/~rkennke/refactor-acmp/webrev.02/
>>> Looks much nicer, go. Only x86, not AArch64?
>> cmpoopptr is a strange name: I'd read it as comparing pointers to oops,
>> not comparing oops.  Which does it actually do?
>>
> it compares oops with oops. cmpoop() is already taken (although we'll
> probably do some refactoring and reuse it later, but it requires some
> upstream work).

cmp_oop_oop ?  Makes much more sense to this reader.


-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671