RFR: Generational/LRU partial heuristics take two...

[Zhengyu Gu]

>
> === Stylistic:
>
> *) ShenandoahHeuristics, stray whitespace at the end:
>
>  205   virtual void choose_collection_set(ShenandoahCollectionSet*
> collection_set, bool minor = false );
>
> *) ShenandoahHeuristics, don't need this:
>
>  272     ShenandoahHeap* heap = ShenandoahHeap::heap();
>
> *) ShenandoahHeuristics, predicate order in the same method:
>
>    if (!hr->is_humongous() && !hr->is_pinned() && !hr->is_empty() &&
>         hr->has_live() && !collection_set->is_in(hr)) {
>
Seems a couple of duplicated checks:

hr->has_live() -> implies !hr->is_empty(), can change to assertion.

!collection_set->is_in(hr) -> can add to cset without additional 
duplication check.


-Zhengyu


> PartialHeuristics:
>