RFR (XS): Fix return type of ShenandoahHeapRegion::region_size_words_jint()

Roman Kennke rkennke at redhat.com
Tue Jul 25 18:37:56 UTC 2017


Andrew Dinn spotted this while reviewing backport to
aarch64-port/jdk8u-shenandoah. The method should return jint (as the
name states) but returns size_t.

diff --git a/src/share/vm/gc/shenandoah/shenandoahHeapRegion.hpp
b/src/share/vm/gc/shenandoah/shenandoahHeapRegion.hpp
--- a/src/share/vm/gc/shenandoah/shenandoahHeapRegion.hpp
+++ b/src/share/vm/gc/shenandoah/shenandoahHeapRegion.hpp
@@ -81,7 +81,7 @@
   }
 
   // Convert to jint with sanity checking
-  inline static size_t region_size_words_jint() {
+  inline static jint region_size_words_jint() {
     assert (ShenandoahHeapRegion::RegionSizeWords <= (size_t)max_jint,
"sanity");
     return (jint)ShenandoahHeapRegion::RegionSizeWords;
   }


I'll push this to jdk10, jdk9, jdk8u and the integration repo.

Ok?



More information about the shenandoah-dev mailing list