RFR: Refactor heap verification

[Zhengyu Gu]

Is this right?

  239   if (ShenandoahVerify) {
  240     ReservedSpace verify_bitmap(_bitmap_size, page_size);
  241     os::commit_memory_or_exit(verify_bitmap.base(), 
verify_bitmap.size(), false,
  242                               "couldn't allocate verification 
bitmap");
  243     MemTracker::record_virtual_memory_type(verify_bitmap.base(), 
mtGC);
  244     MemRegion verify_bitmap_region = MemRegion((HeapWord *) 
verify_bitmap.base(), verify_bitmap.size() / HeapWordSize);
  245     _verification_bit_map.initialize(_heap_region, 
verify_bitmap_region);
  246   }
  247
  248   _verifier = new ShenandoahVerifier(this, &_verification_bit_map);
  249

You want to construct _verifier without initialized bitmap?

-Zhengyu

On 06/01/2017 04:19 PM, Aleksey Shipilev wrote:
> On 06/01/2017 09:37 PM, Aleksey Shipilev wrote:
>> This is the massive refactor of our heap verification:
>>   http://cr.openjdk.java.net/~shade/shenandoah/verifier/webrev.01/
>
> Update:
>   http://cr.openjdk.java.net/~shade/shenandoah/verifier/webrev.02/
>
> -Aleksey
>