RFR: Fast matrix math & inlining
Aleksey Shipilev
shade at redhat.com
Fri Mar 17 17:13:33 UTC 2017
On 03/17/2017 06:06 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/matrixmath/webrev.00/
Very nice.
*) We need to either move the comment from GraphKit to
ShenandoahConnectionMatrix about the math, or reference it otherwise. I would
prefer it moved to SCMatrix, and then GraphKit to mention "look at SCMatrix for
rationale".
*) shenandoahHeap.inline.hpp: redundant to_idx
245 uint to_idx = _heap->heap_region_index_containing(obj);
246 _matrix->set_connected(o, obj);
*) shenandoahHeap.inline.hpp: redundant from_idx
355 uint from_idx = heap_region_index_containing(copy_val);
356 UpdateMatrixClosure cl;
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list