RFR: Adjust heuristics for running with update-refs phase

Roman Kennke rkennke at redhat.com
Tue May 2 18:45:25 UTC 2017


Am 02.05.2017 um 20:34 schrieb Zhengyu Gu:
>
>  498     size_t available =  free_capacity - free_used;
>  499     uintx factor = _free_threshold;
>  500     size_t cset_threshold = 0;
>  501     if (!update_refs_early()) {
>  502       // Count in the memory available after cset reclamation.
>  503       cset_threshold = (size_t) _cset_history->davg();
>  504       size_t cset_threshold = (size_t) _cset_history->davg();
>  505       size_t cset = MIN2(_bytes_in_cset, (cset_threshold *
> capacity) / 100);
>  506       available += cset;
>  507       factor += cset_threshold;
>  508     }
>  509
>
> There are two definitions of cset_threshold variables, and #503 and
> 504 are dup ...

Oops :-)
Fixed with a small followup patch.

Thanks for finding!

Roman




More information about the shenandoah-dev mailing list