RFR: "F: Code Cache Roots" is missing from gc+stats

Aleksey Shipilev shade at redhat.com
Tue May 23 10:05:51 UTC 2017


On 05/23/2017 10:11 AM, Roman Kennke wrote:
> Am 23.05.2017 um 08:39 schrieb Aleksey Shipilev:
>> Hi,
>>
>> This is because we miss one legit ShenandoahRootProcessor use:
>>
>> $ hg diff
>> diff -r 9d9147985937 src/share/vm/gc/shenandoah/shenandoahMarkCompact.cpp
>> --- a/src/share/vm/gc/shenandoah/shenandoahMarkCompact.cpp	Mon May 22 16:20:15
>> 2017 -0400
>> +++ b/src/share/vm/gc/shenandoah/shenandoahMarkCompact.cpp	Tue May 23 08:36:19
>> 2017 +0200
>> @@ -614,7 +614,7 @@
>>    {
>>      COMPILER2_PRESENT(DerivedPointerTable::clear());
>>
>> -    ShenandoahRootProcessor rp(heap, nworkers);
>> +    ShenandoahRootProcessor rp(heap, nworkers,
>> ShenandoahCollectorPolicy::full_gc_roots);
>>      ShenandoahAdjustRootPointersTask task(&rp);
>>      workers->run_task(&task);
>>      COMPILER2_PRESENT(DerivedPointerTable::update_pointers());
>>
>>
>> Thanks,
>> -Aleksey
>>
> Yup

Actually, let's make it more comprehensive by dropping the default argument, and
requiring to pass phase explicitly:
  http://cr.openjdk.java.net/~shade/shenandoah/stats-rp-all/webrev.01/

-Aleksey




More information about the shenandoah-dev mailing list