RFR: More Partial Heuristics

Aleksey Shipilev shade at redhat.com
Wed May 24 18:33:26 UTC 2017


On 05/24/2017 06:44 PM, Aleksey Shipilev wrote:
> On 05/24/2017 03:32 PM, Christine Flood wrote:
>> http://cr.openjdk.java.net/~chf/heuristics/webrev.00/

A few more, after running with it:

*) log_info(gc) in should_start_partial_gc() is noisy. I think it should be
log_info(gc,ergo), and only print if it returns "true".

*) Current patch SEGVs on SPECjbb, because _partial_gc now initializes lazily,
and you need at least this:

bool ShenandoahCollectorPolicy::can_do_partial_gc() {
  return _heuristics->can_do_partial_gc() ||
         _minor_heuristics->can_do_partial_gc();
}

-Aleksey



More information about the shenandoah-dev mailing list