RFR: couple small strip mining fixes

Aleksey Shipilev shade at redhat.com
Thu Oct 19 09:02:20 UTC 2017


On 10/19/2017 10:25 AM, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/shenandoah/couplestripminingfixes/webrev.00/

Looks good.

The space styling is inconsistent though (that is to say the original style is bad, but we can at
least match it):

  if( !r->is_Region() ) return NULL;
  if (r->is_Loop() && r->in(LoopNode::LoopBackControl)->is_top()) return NULL; // going away anyway
  if( phi->region() != r ) return NULL;

Should be:

  if( !r->is_Region() ) return NULL;
  if( r->is_Loop() && r->in(LoopNode::LoopBackControl)->is_top() ) return NULL; // going away anyway
  if( phi->region() != r ) return NULL;


Thanks,
-Aleksey



More information about the shenandoah-dev mailing list