RFR: couple small strip mining fixes
Aleksey Shipilev
shade at redhat.com
Thu Oct 19 09:07:10 UTC 2017
On 10/19/2017 11:03 AM, Aleksey Shipilev wrote:
> On 10/19/2017 11:02 AM, Aleksey Shipilev wrote:
>> On 10/19/2017 10:25 AM, Roland Westrelin wrote:
>>> http://cr.openjdk.java.net/~roland/shenandoah/couplestripminingfixes/webrev.00/
>>
>> Looks good.
>>
>> The space styling is inconsistent though (that is to say the original style is bad, but we can at
>> least match it):
>>
>> if( !r->is_Region() ) return NULL;
>> if (r->is_Loop() && r->in(LoopNode::LoopBackControl)->is_top()) return NULL; // going away anyway
>> if( phi->region() != r ) return NULL;
>>
>> Should be:
>>
>> if( !r->is_Region() ) return NULL;
>> if( r->is_Loop() && r->in(LoopNode::LoopBackControl)->is_top() ) return NULL; // going away anyway
>> if( phi->region() != r ) return NULL;
>
> Wait! Need to check if this is neutral under !UseShenandoahGC.
...or not. I suppose this is the loop strip mining code that would be replaced by the upstream LSM
code you are doing now? If so, we can keep it in sh/jdk10. This would not be backported anyhow,
since LSM is present only in sh/jdk10. Does this capture the intent right?
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list