RFR: couple small strip mining fixes

Aleksey Shipilev shade at redhat.com
Thu Oct 19 09:14:22 UTC 2017


On 10/19/2017 11:13 AM, Roland Westrelin wrote:
> 
>> The space styling is inconsistent though (that is to say the original style is bad, but we can at
>> least match it):
>>
>>   if( !r->is_Region() ) return NULL;
>>   if (r->is_Loop() && r->in(LoopNode::LoopBackControl)->is_top()) return NULL; // going away anyway
>>   if( phi->region() != r ) return NULL;
>>
>> Should be:
>>
>>   if( !r->is_Region() ) return NULL;
>>   if( r->is_Loop() && r->in(LoopNode::LoopBackControl)->is_top() ) return NULL; // going away anyway
>>   if( phi->region() != r ) return NULL;
> 
> The usual practice in c2 code is to only use the new style and clean
> things up around the code that is changed. This said, cleaning things up
> will make merging from upstream trickier.
> 
> Anyway, that change is part of my loop strip mining patch that is being
> reviewed upstream. If there's a need to fix the coding style, it will
> happen upstream and we'll get it at some point. So I would leave the
> patch as it is.

OK.

-Aleksey



More information about the shenandoah-dev mailing list