RFR: AESCrypt.implEncryptBlock/AESCrypt.implDecryptBlock intrinsics assume non null inputs

Aleksey Shipilev shade at redhat.com
Fri Oct 20 12:04:33 UTC 2017


On 10/20/2017 01:57 PM, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/shenandoah/aesintrinsicsnonnull/webrev.00/

Looks good and trivial to me.

The use of must_be_not_null on non-Shenandoah paths concerns me a little, but it seems to be in line
with what we are already doing:

https://builds.shipilev.net/patch-openjdk-shenandoah-jdk10/2017-10-20-v174-vs-74700c8e39e9/src/hotspot/share/opto/library_call.cpp.sdiff.html

This, BTW, makes me think if we want to put must_be_not_null inside shenandoah_*_barrier to make it
perfectly neutral.

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list