Updated fix for jdk10 Generational Partial Heuristics...

[Christine Flood]

http://cr.openjdk.java.net/~chf/GenerationalHeuristics/webrev.05/

On Tue, Sep 12, 2017 at 1:32 PM, Aleksey Shipilev <shade at redhat.com> wrote:

> You are replying offlist.
>
> Okay. Then you should run initialize() on all heuristics, not only on
> minor one.
>
> -Aleksey
>
> On 09/12/2017 07:29 PM, Christine Flood wrote:
> > I like the num_regions solution but unfortunately the heap isn't
> initialized yet so we don't have
> > access to it.
> >
> > There is precedent for running initialize after creating the instance
> (we do it for heap) and it's
> > cleaner once we have all the data we need to get the right settings
> rather than passing in
> > parameters to constructors.
> >
> > Christine
> >
> >
> >
> > On Tue, Sep 12, 2017 at 12:54 PM, Aleksey Shipilev <shade at redhat.com
> <mailto:shade at redhat.com>> wrote:
> >
> >     On 09/12/2017 06:51 PM, Aleksey Shipilev wrote:
> >     >  *) Seems to me that entire deal with initialize() method can be
> gone if ShenandoahPartialHeuristics
> >     > constructor accepts the size_t parameter for from_idxs
> initialization. You can seed it off the
> >     > static const:
> >     >
> >     >   static const size_t DEFAULT_THRESHOLD = 100;
> >     >
> >     >   ShenandoahGenerationalPartialHeuristics() :
> ShenandoahPartialHeuristics(DEFAULT_THRESHOLD) {
> >     >     if (FLAG_IS_DEFAULT(ShenandoahPartialInboundThreshold)) {
> >     >       FLAG_SET_DEFAULT(ShenandoahPartialInboundThreshold,
> DEFAULT_THRESHOLD);
> >     >     }
> >     >   }
> >
> >     Or screw it, and just initialize from_idx with num_regions() size?
> >
> >     -Aleksey
> >
> >
> >
> >
>
>
>