RFR: Fixup roots after partial GC failed

Aleksey Shipilev shade at redhat.com
Fri Sep 15 14:22:57 UTC 2017


On 09/15/2017 04:15 PM, Zhengyu Gu wrote:
> We need to fixup roots after partial failed (just as SH::evacuate_and_update()). full-gc's
> update_roots() does not do the trick, 'cause it crosses safepoints, frames moved.
> 
> 
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/evac_dpt/webrev.00/index.html

Looks good to me.

It is weird to see that partial GC abort is also handled by conc_gc_cancelled flag. This assumes we
are sliding into Full GC at that point, right?

 341   } else {
 342     // Fixup roots to make them consistent
 343     _heap->fixup_roots();
 344   }

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list